Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build PSP components as a separate targets #169

Closed
jphickey opened this issue Jun 16, 2020 · 0 comments · Fixed by #172 or #176
Closed

Build PSP components as a separate targets #169

jphickey opened this issue Jun 16, 2020 · 0 comments · Fixed by #172 or #176
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As part of coverage testing that is being introduced in #168, it will require rebuilding the PSP code more than once, to make a variant that include coverage instrumentation. This requires a bit of restructuring to support.

Describe the solution you'd like
Build components (e.g. shared directory) as separate targets so they can be added more than once with different configurations.
Define all target names using a separate re-definable string such as ${CFE_PSP_TARGETNAME} rather than ${CFE_SYSTEM_PSPNAME} to avoid target name conflicts.

Additional context
Prerequisite to #168, isolated to separate issue because it affects FSW headers and build scripts, not just unit test, and therefore warrants separate review.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 16, 2020
@jphickey jphickey added the enhancement New feature or request label Jun 16, 2020
jphickey added a commit to jphickey/PSP that referenced this issue Jun 16, 2020
@jphickey
Fix nasa#169, make separate targets for PSP
0c7469d 
Restructure code to make more amicable for rebuilding in a unit test environment.
No major changes, primarily just shifting code between locations/headers to support
unit testing.
jphickey added a commit to jphickey/PSP that referenced this issue Jun 16, 2020
@jphickey
Fix nasa#169, make separate targets for PSP
e5f4bbc 
Restructure code to make more amicable for rebuilding in a unit test environment.
No major changes, primarily just shifting code between locations/headers to support
unit testing.
@jphickey jphickey mentioned this issue Jun 16, 2020
Merged
astrogeco added a commit that referenced this issue Jul 1, 2020
@astrogeco
Merge pull request #172 from jphickey/fix-169-psp-target-reconfig
a21a1d8 
Fix #169, make separate targets for PSP
@astrogeco astrogeco mentioned this issue Jul 1, 2020
Merged
@astrogeco astrogeco added this to the 1.5.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #169, make separate targets for PSP jphickey/PSP
Integration Candidate: 2020-06-24 nasa/PSP
2 participants
@jphickey @astrogeco