Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #169, make separate targets for PSP #172

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Restructure code to make more amicable for rebuilding in a unit test environment. No major changes, primarily just shifting code between locations/headers to support unit testing.

Fixes #169

Testing performed
Build and sanity check CFE on RTEMS and Linux
Run all unit tests and confirm passing.

Expected behavior changes
No impact to behavior.

System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3 via QEMU/pc686

Additional context
Makes the code structure better for unit testing.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Restructure code to make more amicable for rebuilding in a unit test environment.
No major changes, primarily just shifting code between locations/headers to support
unit testing.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 16, 2020
@astrogeco
Copy link
Contributor

CCB 2020-06-17: @skliper and @jphickey will have a splinter to discuss design approach

@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 18, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate June 22, 2020 19:42
@astrogeco astrogeco added CCB:Approved Indicates Approval by CCB IC-20200617 and removed IC-20200617 CCB:Approved Indicates Approval by CCB labels Jun 22, 2020
@astrogeco astrogeco changed the base branch from integration-candidate to master June 23, 2020 19:08
@astrogeco
Copy link
Contributor

@skliper and @jphickey what's the status on this?

@jphickey
Copy link
Contributor Author

So far we haven't had a splinter meeting about this but I'm happy to do so any time. The unique case here is that it is building the UT for potentially other targets than what the FSW is built for (like OSAL coverage) but unlike OSAL coverage it is building it as one unit, not separate units. So IMO this use-case made sense to use the same CMakeLists.txt subdir files create the same targets but with a different name.

Ideally in a future version I'd like to pursue the concept of a fully-modular PSP, where the PSP is just an assembly of extra modules linked into cfe core. Then each module can get its own separate coverage test. But in the meantime I think this works for the current PSP architecture.

@skliper
Copy link
Contributor

skliper commented Jun 24, 2020

I'm good with it, just needed to look again. I also really like the direction of treating PSP as an assembly of extra modules.

@astrogeco
Copy link
Contributor

I'm good with it, just needed to look again. I also really like the direction of treating PSP as an assembly of extra modules.

So should I add it to IC-20200617?

@skliper
Copy link
Contributor

skliper commented Jun 24, 2020

I'm good with it, just needed to look again. I also really like the direction of treating PSP as an assembly of extra modules.

So should I add it to IC-20200617?

Yes please! The sooner the better.

@astrogeco astrogeco changed the base branch from master to integration-candidate July 1, 2020 13:49
@astrogeco astrogeco merged commit a21a1d8 into nasa:integration-candidate Jul 1, 2020
@skliper skliper added this to the 1.5.0 milestone Aug 21, 2020
@jphickey jphickey deleted the fix-169-psp-target-reconfig branch January 6, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build PSP components as a separate targets
3 participants