PSP Integration candidate: Equuleus-rc1+dev18 #437
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| static uint32 CFE_PSP_ConfigPspModuleListLength = 0; | ||
| static uint32 CFE_PSP_StandardPspModuleListLength = 0; | ||
| CFE_PSP_ModuleListGlobal_t CFE_PSP_MODULE_LIST_GLOBAL; |
Check notice
Code scanning / CodeQL
Global could be static Note
|
|
||
| /*************************************************** | ||
| * | ||
| * Helper function to initialize a list of modules (not externally called) | ||
| * Returns the number of modules initialized | ||
| */ | ||
| uint32_t CFE_PSP_ModuleInitList(uint32 BaseId, CFE_StaticModuleLoadEntry_t *ListPtr) | ||
| void CFE_PSP_ModuleInitList(CFE_PSP_ModuleListWrapper_t *WrapPtr, uint32 BaseId, CFE_StaticModuleLoadEntry_t *ListPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * See prototype for full description | ||
| */ | ||
| int32 CFE_PSP_Module_FindByName(const char *ModuleName, uint32 *PspModuleId) | ||
| uint32 CFE_PSP_Module_SearchNameInList(const CFE_PSP_ModuleListWrapper_t *WrapPtr, const char *ModuleName) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * | ||
| * See prototype for full description | ||
| */ | ||
| int32 CFE_PSP_Module_FindByName(const char *ModuleName, uint32 *PspModuleId) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
|
As there is no rush to get this into the open source build, I suggest postponing this merge until next cycle. In addition to the RTEMS build issue and the leftover commented-out lines, I found a couple other fixups I'd like to include. I will add a follow-up commit and we can [re]review next CCB. |
Adds a coverage test implementation for all existing PSP modules. This should get 100% coverage on all lines and branches.
The cpu number to poll was not range checked until _after_ the memset. This is not the correct order of operations, it must range the element number in the array before writing/clearing it.
The handler executes after the stub count increments, thus this needs to check for 1 to indicate the first call, not 0.
Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows
Fix #435, add coverage tests for PSP modules
dzbaker
force-pushed
the
integration-candidate
branch
from
c3ad770
to
d2e641f
Compare
dzbaker
changed the title
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
PSP Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 22.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey