Functional ES task test does math on a pointer size which results in different behavior for 32 vs 64bit

[skliper]

Is your feature request related to a problem? Please describe.
Dodgy test on line 221 fails on a 32 bit machine since 0 length returns a different error vs a buffer that is too small:

cFE/modules/cfe_testcase/src/es_task_test.c

Lines 195 to 221 in 64a6a59

	const char * TaskName = "CHILD_TASK_1";
	const char INVALID_TASK_NAME[] = "INVALID_NAME";
	CFE_ES_TaskId_t TaskIdByName;
	char TaskNameBuf[OS_MAX_API_NAME + 4];
	CFE_ES_StackPointer_t StackPointer = CFE_ES_TASK_STACK_ALLOCATE;
	size_t StackSize = CFE_PLATFORM_ES_PERF_CHILD_STACK_SIZE;
	CFE_ES_TaskPriority_Atom_t Priority = CFE_PLATFORM_ES_PERF_CHILD_PRIORITY;
	uint32 Flags = 0;
	UtAssert_INT32_EQ(CFE_ES_CreateChildTask(&TaskId, TaskName, TaskFunction, StackPointer, StackSize, Priority, Flags),
	CFE_SUCCESS);
	UtAssert_INT32_EQ(CFE_ES_GetTaskIDByName(&TaskIdByName, TaskName), CFE_SUCCESS);
	CFE_UtAssert_RESOURCEID_EQ(TaskIdByName, TaskId);
	UtAssert_INT32_EQ(CFE_ES_GetTaskName(TaskNameBuf, TaskId, sizeof(TaskNameBuf)), CFE_SUCCESS);
	UtAssert_StrCmp(TaskNameBuf, TaskName, "CFE_ES_GetTaskName() = %s", TaskNameBuf);
	UtAssert_INT32_EQ(CFE_ES_GetTaskIDByName(NULL, TaskName), CFE_ES_BAD_ARGUMENT);
	UtAssert_INT32_EQ(CFE_ES_GetTaskIDByName(&TaskIdByName, NULL), CFE_ES_BAD_ARGUMENT);
	UtAssert_INT32_EQ(CFE_ES_GetTaskIDByName(&TaskIdByName, INVALID_TASK_NAME), CFE_ES_ERR_NAME_NOT_FOUND);
	CFE_UtAssert_RESOURCEID_UNDEFINED(TaskIdByName);
	UtAssert_INT32_EQ(CFE_ES_GetTaskName(NULL, TaskId, sizeof(TaskNameBuf)), CFE_ES_BAD_ARGUMENT);
	UtAssert_INT32_EQ(CFE_ES_GetTaskName(TaskNameBuf, CFE_ES_TASKID_UNDEFINED, sizeof(TaskNameBuf)),
	CFE_ES_ERR_RESOURCEID_NOT_VALID);
	UtAssert_INT32_EQ(CFE_ES_GetTaskName(TaskNameBuf, TaskId, sizeof(TaskName) - 4), CFE_ES_ERR_RESOURCEID_NOT_VALID);

sizeof(TaskName) is either 4 or 8 since it's defined as a pointer on line 195. I think the intent was to pass in a buffer length that is too small.

Describe the solution you'd like
Do a 0 buffer length test and a buffer length to small test separately (and fix). Also the INVALID_NAME doesn't really follow case or use patterns, just pass in an invalid constant.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC