Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1959, Make invalid buffer length consistent in es task test #1960

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fix #1959, Make invalid buffer length consistent in es task test #1960

merged 1 commit into from
Sep 21, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 16, 2021 •
edited
Loading

Describe the contribution

Changes:

  • Makes the TestName into an array (and just subtracts 1)
  • Removes the const invalid test name
  • Tests against 0 buffer length

Testing performed
Ran on MCP750

Expected behavior changes
Tests both too short and 0 buffer length.

System(s) tested on

  • Hardware: MCP750
  • OS: VxWorks 6.9
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 16, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 16, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate September 21, 2021 14:58
@astrogeco astrogeco mentioned this pull request Sep 21, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 21, 2021
@astrogeco
nasa/cFE#1960, Make invalid buffer length consistent in es task test
a0b2c64
@astrogeco astrogeco merged commit e87b7de into nasa:integration-candidate Sep 21, 2021
astrogeco added a commit that referenced this pull request Sep 21, 2021
@astrogeco
Hotfix #1967, Rename CFE_UtAssert in functional
3c35e2b 
Errant CFE_UtAssert snuck in with merge of #1960
@astrogeco astrogeco mentioned this pull request Sep 21, 2021
Merged
2 tasks
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 22, 2021
astrogeco added a commit to astrogeco/cFS that referenced this pull request Sep 22, 2021
@astrogeco @skliper
@jphickey @Nodraak
IC:2021-09-21
358b547 
**Combines**

nasa/cFE#1967 v6.8.0-rc1+dev1024

nasa/osal#1158 v5.1.0-rc1+dev619

nasa/sch_lab#92 v2.4.0-rc1+dev53

nasa/sample_app#155 v1.2.0-rc1+dev73

nasa/to_lab#105 v2.4.0-rc1+dev58

nasa/ci_lab#93 v2.4.0-rc1+dev46

**Includes:**

*cFE*

nasa/cFE#1948, Update name of macros/functions added to "cfe_assert"

nasa/cFE#1950, Fix Mismatch between MSG API and test case in "TestMsgId" functional test

nasa/cFE#1962, Single time domain in functional time tests

nasa/cFE#1943, add missing inclusions in CFE API headers

nasa/cFE#1964, Use existing /ram for FS header test

nasa/cFE#1956, Add static local to function test so data section is nonzero

nasa/cFE#1960, Make invalid buffer length consistent in es task test

nasa/cFE#1953, Only check base filename in library info functional

nasa/cFE#1970, Confirm sb/time reset requirements in coverage test

nasa/cFE#1947, Fix broken link in App Developers Guide

nasa/cFE#1972, Fix #1971, avoid alias warning on some compilers

*osal*

nas/osal#1149, Enable symbol api test and MIR dump too large

nasa/osal#1152, Fix OSAL loader test hard fails if size exceeded

nasa/osal#1155, add bsp-specific configuration flag registry

nasa/osal#1157, Add os-specifc socket flag function

*Apps*

nasa/ci_lab#92, Apply CFE_SB_ValueToMsgId where required

nasa/sample_app#154, Apply CFE_SB_ValueToMsgId where required

nasa/sch_lab#91, Apply CFE_SB_ValueToMsgId where required

nasa/to_lab#104, Apply CFE_SB_ValueToMsgId where required

Co-authored-by: Jacob Hageman   <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey   <jphickey@users.noreply.github.com>
Co-authored-by: Adrien Chardon  <nodraak@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 22, 2021
@astrogeco @skliper
@jphickey @Nodraak
IC:2021-09-21
a1b140e 
**Combines**

nasa/cFE#1967 v6.8.0-rc1+dev1024

nasa/osal#1158 v5.1.0-rc1+dev619

nasa/sch_lab#92 v2.4.0-rc1+dev53

nasa/sample_app#155 v1.2.0-rc1+dev73

nasa/to_lab#105 v2.4.0-rc1+dev58

nasa/ci_lab#93 v2.4.0-rc1+dev46

**Includes:**

*cFE*

nasa/cFE#1948, Update name of macros/functions added to "cfe_assert"

nasa/cFE#1950, Fix Mismatch between MSG API and test case in "TestMsgId" functional test

nasa/cFE#1962, Single time domain in functional time tests

nasa/cFE#1943, add missing inclusions in CFE API headers

nasa/cFE#1964, Use existing /ram for FS header test

nasa/cFE#1956, Add static local to function test so data section is nonzero

nasa/cFE#1960, Make invalid buffer length consistent in es task test

nasa/cFE#1953, Only check base filename in library info functional

nasa/cFE#1970, Confirm sb/time reset requirements in coverage test

nasa/cFE#1947, Fix broken link in App Developers Guide

nasa/cFE#1972, Fix #1971, avoid alias warning on some compilers

*osal*

nas/osal#1149, Enable symbol api test and MIR dump too large

nasa/osal#1152, Fix OSAL loader test hard fails if size exceeded

nasa/osal#1155, add bsp-specific configuration flag registry

nasa/osal#1157, Add os-specifc socket flag function

*Apps*

nasa/ci_lab#92, Apply CFE_SB_ValueToMsgId where required

nasa/sample_app#154, Apply CFE_SB_ValueToMsgId where required

nasa/sch_lab#91, Apply CFE_SB_ValueToMsgId where required

nasa/to_lab#104, Apply CFE_SB_ValueToMsgId where required

Co-authored-by: Jacob Hageman   <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey   <jphickey@users.noreply.github.com>
Co-authored-by: Adrien Chardon  <nodraak@users.noreply.github.com>
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB functional and removed unit-test labels Sep 22, 2021
@astrogeco
Copy link
Contributor

CCB:2021-09-21 APPROVED

@skliper skliper deleted the fix1959-es_task_test branch October 22, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanzaben zanzaben zanzaben approved these changes

@pepepr08 pepepr08 Awaiting requested review from pepepr08

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB functional
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Functional ES task test does math on a pointer size which results in different behavior for 32 vs 64bit
3 participants
@skliper @astrogeco @zanzaben