Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CFE_SB_SendMsgFull() to match latest SBN function prototype #292

Closed
skliper opened this issue Sep 30, 2019 · 6 comments
Closed

Update CFE_SB_SendMsgFull() to match latest SBN function prototype #292

skliper opened this issue Sep 30, 2019 · 6 comments
Labels
invalid

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Reported by Astrobotic 12/28/18 via email.

The SBN product has a prototype of int32 CFE_SB_SendMsgFull(CFE_SB_Msg_t *MsgPtr, uint32 TlmCntIncrements, uint32 CopyMode, CFE_SB_SenderId_t *SenderPtr) (4 variables)

The SB prototype has 3 int32 CFE_SB_SendMsgFull(CFE_SB_Msg_t *MsgPtr, uint32 TlmCntIncrements, uint32 CopyMode); There is a conflict between the header files.
@skliper skliper added this to the 6.7.1 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 261. Created by dcmccom3 on 2019-01-31T12:47:52, last modified: 2019-07-03T12:48:08

@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-03 12:48:08:

Moved unfinished 6.6.1 issues to next minor release

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper modified the milestones: 6.7.1, 6.7.0, 6.8.0 Sep 30, 2019
@skliper skliper removed this from the 6.8.0 milestone Nov 4, 2019
@skliper
Copy link
Contributor Author

skliper commented Nov 4, 2019

Needs more investigation/documentation and a design/architectural discussion. If the SBN call is different, it doesn't conform with the currently defined API.

@skliper skliper added enhancement and removed bug labels Nov 4, 2019
@skliper
Copy link
Contributor Author

skliper commented Nov 4, 2019

Related to #127, which is a request for this API change.

@skliper skliper mentioned this issue Nov 4, 2019
Closed
skliper added a commit that referenced this issue Nov 15, 2019
@skliper
20191106/13: Merge #387 #390 #391 #393 #395 #400
a11f38b 
Fixes #379, Fixes #380, Fixes #383, Fixes #384,
Fixes #385, Fixes #292
Code reviewed and approved at 20191106 and 20191113 CB
@skliper skliper mentioned this issue Nov 19, 2019
Merged
@skliper
Copy link
Contributor Author

skliper commented Nov 30, 2019

Note the two references above for ic-20191115 were because of a link typo. There was no work on this issue as part of that pull request.

This was referenced Jun 29, 2020
Closed
Closed
@skliper
Copy link
Contributor Author

skliper commented Oct 1, 2020

OBE - marking invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CDKnightNASA @skliper