Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #380: Exclude unit tests from lcov report #395

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 6, 2019

Describe the contribution
Fixes #380, exclude unit-test files from lcov report

Testing performed
Steps taken to test the contribution:

  1. Build/test/run lcov
make distclean
make ENABLE_UNIT_TESTS=TRUE SIMULATION=native prep
make
make install
make test
make lcov
  1. Processed files no longer include unit test code, confirmed processed file list against repo
  2. Coverage from 6.7.0 was
lines......: 92.6% (20233 of 21841 lines)
functions..: 95.9% (827 of 862 functions)

with unit test files included, now

  lines......: 98.6% (8195 of 8308 lines)
  functions..: 99.6% (471 of 473 functions)

Expected behavior changes
Valid coverage of flight code now reported

System(s) tested on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 16.04
  • Versions: master bundle with this change

Additional context
None

Contributor Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Nov 7, 2019
@skliper skliper changed the base branch from master to merge-20191115 November 15, 2019 19:46
@skliper skliper merged commit 3a60668 into merge-20191115 Nov 15, 2019
@skliper skliper deleted the fix-380-exclude-ut-lcov branch November 15, 2019 19:46
skliper added a commit that referenced this pull request Nov 15, 2019
Fixes #379, Fixes #380, Fixes #383, Fixes #384,
Fixes #385, Fixes #292
Code reviewed and approved at 20191106 and 20191113 CB
skliper added a commit that referenced this pull request Nov 30, 2019
Fixes #379, Fixes #380, Fixes #383, Fixes #384,
Fixes #385, Fixes #392
Code reviewed and approved at 20191106 and 20191113 CB
@skliper skliper added this to the 6.8.0 milestone Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant