Fix #986, Remove unnecessary CFE_MSG_Init in TBL #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
skliper
added
CCB:FastTrack
and removed
CCB:Ready
skliper
force-pushed
the
fix986-tbl_msg_init
branch
from
d977b0e
to
4a86e23
Compare
CCB:2021-01-27 APPROVED |
astrogeco
force-pushed
the
integration-candidate
branch
from
54dffe8
to
f6c6737
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #986 - removed the
HkPacketandTblRegPacketmessage initializations fromCFE_TBL_EarlyInit, they are initialized inCFE_TBL_InitData. Moved theNotifyMsgmessage initialization toCFE_TBL_InitData, and just setting the message ID each time it's sent fromCFE_TBL_SendNotificationMsg.Testing performed
Build and run unit tests, passed.
Expected behavior changes
None (or just slightly better performance since the msg isn't initialized every call)
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC