Fix #1679, Add functional tests for resource misc #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanzaben
suggested changes
Aug 10, 2021
jphickey
reviewed
Aug 11, 2021
nmullane
force-pushed
the
fix1679-resource-misc-functional-tests
branch
from
8eafd69
to
f1b7720
Compare
|
This PR depends on #1790 |
nmullane
force-pushed
the
fix1679-resource-misc-functional-tests
branch
from
f1b7720
to
a3801df
Compare
|
This doesn't build with set(MISSION_RESOURCEID_MODE STRICT). @jphickey is that still an issue? |
Yes, thanks for catching - we need to fix that before merging! All new code should be consistent and use the correct typedef to store an ID (not a uint32!) |
jphickey
requested changes
Aug 18, 2021
There was a problem hiding this comment.
Need to fix all the ID type inconsistencies in here, example case noted in separate comment but there are several similar issues throughout.
Need to enable the strict (type-safe) mode to see the issues. Just add:
set(MISSION_RESOURCEID_MODE STRICT)
to your sample_defs/global_build_options.cmake file to turn this mode on.
skliper
reviewed
Aug 18, 2021
|
CCB:2021-08-18 APPROVED with CHANGES
|
astrogeco
added
the
CCB:Approved
- Fixed test to work with strict resource id types
nmullane
force-pushed
the
fix1679-resource-misc-functional-tests
branch
from
a3801df
to
d02ccd8
Compare
|
Tests pass in fork |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 20, 2021
This was referenced Aug 20, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 21, 2021
**Combines** nasa/cFE# v6.8.0-rc1+dev933 nasa/osal# v5.1.0-rc1+dev594 **Includes** *osal* nasa/osal#1131, add test case types similar to NA *cFE* nasa/cFE#1803, Add software bus tests nasa/cFE#1756, separate variable for OSAL status nasa/cFE#1809, increase SB pool max size bucket nasa/cFE#1842, Add Null check for CFE_ResourceId_FindNext nasa/cFE#1828, Improve TBL coverage tests nasa/cFE#1833, Clean up Message ID Functional Test #1824, Add missing cases for msg id func tests nasa/cFE#1832, Combine SB Set/Get message characteristics group #1831, Consolidate msg get/set doxygen group nasa/cFE#1836, Adding coverage tests to cFE TIME nasa/cFE#1848, enable strict resource id w/OMIT_DEPRECATED nasa/cFE#1845, HOTFIX IC-20210819, type correction TBL coverage test nasa/cFE#1806, Add test for ES BackgroundWakeup nasa/cFE#1813, Success Test for CFE_ES_RestartApp nasa/cFE#1814, Subscribe to Message Limit Greater Than CFE_PLATFORM_SB_DEFAULT_MSG_LIMIT nasa/cFE#1811, Success Test for CFE_ES_GetMemPoolStats nasa/cFE#1822, Group MSG APIs documentation by header type nasa/cFE#1816, add retroactive CFE status asserts nasa/cFE#1854, remove unused CFE_TBL_ERR_BAD_APP_ID nasa/cFE#1855, correct syslog message in pool create nasa/cFE#1853, remove unused CFE_ES_POOL_BOUNDS_ERROR nasa/cFE#1859, remove unused CFE_TBL_ERR_FILE_NOT_FOUND nasa/cFE#1856, Check error ctr to TransmitMsg test nasa/cFE#1857, End Child Task requirement remove error code nasa/cFE#1782, Add functional tests for resource misc Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Testing performed
Expected behavior changes
No impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern