Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2205, Enforce strict cast alignment on arch #2206

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 10, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
None, just enforces strict alignment and currently compliant

System(s) tested on
CI

Additional context
Note this strict option isn't supported by clang so would need to be removed along with -Wno-format-truncation and -Wno-stringop-truncation

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Nov 10, 2022
@skliper
Copy link
Contributor Author

skliper commented Nov 14, 2022

cFE and workflows need to use Ubuntu 20.04 at minimum for this flag to work:

Error w/o dependency can be seen here:
https://github.com/nasa/cFE/actions/runs/3440671428/jobs/5739398455

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Nov 17, 2022
dzbaker added a commit that referenced this pull request Nov 23, 2022
Fix #2205, Enforce strict cast alignment on arch
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 23, 2022
*Combines:*

osal v6.0.0-rc4+dev165
cFE v7.0.0-rc4+dev215
sample_lib v1.3.0-rc4+dev32

**Includes:**

*osal*
- nasa/osal#1334

*cFE*
- nasa/cFE#2209
- nasa/cFE#2206
- nasa/cFE#2204
- nasa/cFE#2203

*sample_lib*
- nasa/sample_lib#92

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
The -Wcast-align=strict option only works with certain versions of gcc.
This moves it to the "native" custom options, so it will not be used on
cross builds.
@skliper
Copy link
Contributor Author

skliper commented Nov 23, 2022

@jphickey that's a good fix... did you want to separate out the other non clang flags also?

dzbaker added a commit to nasa/cFS that referenced this pull request Nov 28, 2022
*Combines:*

osal v6.0.0-rc4+dev165
cFE v7.0.0-rc4+dev218
sample_lib v1.3.0-rc4+dev32

**Includes:**

*osal*
- nasa/osal#1334

*cFE*
- nasa/cFE#2209
- nasa/cFE#2206
- nasa/cFE#2204
- nasa/cFE#2203

*sample_lib*
- nasa/sample_lib#92

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
@dzbaker dzbaker merged commit f724dbc into nasa:main Nov 28, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 28, 2022
*Combines:*

osal v6.0.0-rc4+dev165
cFE v7.0.0-rc4+dev218
sample_lib v1.3.0-rc4+dev32

**Includes:**

*osal*
- nasa/osal#1334

*cFE*
- nasa/cFE#2209
- nasa/cFE#2206
- nasa/cFE#2204
- nasa/cFE#2203

*sample_lib*
- nasa/sample_lib#92

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
@skliper skliper deleted the fix2205-strict_cast_align branch September 1, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB dependency draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce strict cast alignment
4 participants