Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #91, Add newline at end of sample_lib.c #92

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 10, 2022

Describe the contribution

Testing performed
CI, also built w/ clang and it resolves the warning

Expected behavior changes
No clang warning, no impact for gnu compilers

System(s) tested on
CI and w/ Clang 10

Additional context
Related to:

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready PR or Issue is ready for discussion at the Configuration Control Board (CCB) label Nov 10, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready PR or Issue is ready for discussion at the Configuration Control Board (CCB) labels Nov 17, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 23, 2022
*Combines:*

osal v6.0.0-rc4+dev165
cFE v7.0.0-rc4+dev215
sample_lib v1.3.0-rc4+dev32

**Includes:**

*osal*
- nasa/osal#1334

*cFE*
- nasa/cFE#2209
- nasa/cFE#2206
- nasa/cFE#2204
- nasa/cFE#2203

*sample_lib*
- nasa/sample_lib#92

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 28, 2022
*Combines:*

osal v6.0.0-rc4+dev165
cFE v7.0.0-rc4+dev218
sample_lib v1.3.0-rc4+dev32

**Includes:**

*osal*
- nasa/osal#1334

*cFE*
- nasa/cFE#2209
- nasa/cFE#2206
- nasa/cFE#2204
- nasa/cFE#2203

*sample_lib*
- nasa/sample_lib#92

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
@dzbaker dzbaker merged commit 956f305 into nasa:main Nov 28, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 28, 2022
*Combines:*

osal v6.0.0-rc4+dev165
cFE v7.0.0-rc4+dev218
sample_lib v1.3.0-rc4+dev32

**Includes:**

*osal*
- nasa/osal#1334

*cFE*
- nasa/cFE#2209
- nasa/cFE#2206
- nasa/cFE#2204
- nasa/cFE#2203

*sample_lib*
- nasa/sample_lib#92

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
@skliper skliper deleted the fix91-no_newline branch April 1, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing newline at end of sample_lib.c
2 participants