Unloading module after failed app start #2616
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichLandau
requested changes
Dec 2, 2024
modules/es/fsw/src/cfe_es_apps.c
Outdated
| @@ -799,6 +799,10 @@ int32 CFE_ES_AppCreate(CFE_ES_AppId_t *ApplicationIdPtr, const char *AppName, co | |||
| /* | |||
| * Set the table entry back to free | |||
| */ | |||
| if (OS_ObjectIdDefined(AppRecPtr->LoadStatus.ModuleId)) { | |||
| OS_ModuleUnload(AppRecPtr->LoadStatus.ModuleId); | |||
There was a problem hiding this comment.
Please capture the return code and log on error.
tandharia
force-pushed
the
fix-2615-unloading-module
branch
2 times, most recently
from
79d1bbf to
9db4d27
Compare
RichLandau
approved these changes
Dec 5, 2024
|
CCB 5 December 2024: Provisionally approved pending squash of commits. |
tandharia
force-pushed
the
fix-2615-unloading-module
branch
from
9db4d27 to
f35e304
Compare
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #2615 - Unloading module from memory when an app fails to start
Testing performed
Built and ran all tests
Expected behavior changes
If an app fails to start because of bad parameters, the module is unloaded from memory and the entry in the OS_module_table removed
System(s) tested on
OS: RHEL 8.10
Contributor Info - All information REQUIRED for consideration of pull request
Tvisha Andharia - GSFC 582 intern