Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #487, CFE_TIME_print format fix #504

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

dmknutsen
Copy link
Contributor

@dmknutsen dmknutsen commented Jan 31, 2020

Describe the contribution
Fix #487, CFE_TIME_print format fix

Testing performed
Build process:

  • make distclean
  • make ENABLE_UNIT_TESTS=TRUE SIMULATION=native prep
  • make
  • make install

Verified nominal/clean build.
Ran unit tests.

Expected behavior changes
Clean build

System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-18.04.3
Versions: cFE 6.7.6.0, OSAL 5.0.6.0, PSP 1.4.4.0

Contributor Info
Dan Knutsen
GSFC/NASA

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs squash

@skliper
Copy link
Contributor

skliper commented Jan 31, 2020

Preferred commit text:

Fix #487, CFE_TIME_print format fix

Cast and format now int to avoid possible string buffer overflow

@dmknutsen dmknutsen force-pushed the issue_487 branch 2 times, most recently from ceed766 to d96c802 Compare January 31, 2020 16:34
@dmknutsen dmknutsen changed the title Fix #487, Build failure of ut_time_stubs with BUILDTYPE=release Fix #487, CFE_TIME_print format fix Feb 11, 2020
@skliper
Copy link
Contributor

skliper commented Feb 25, 2020

@dmknutsen could you make this a multi-line commit message? The one long line messes with formatting. Just commit without the -m (and message), and git will allow you to do multiline within an editor.

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 25, 2020
@skliper
Copy link
Contributor

skliper commented Feb 25, 2020

@astrogeco please prioritize, this one is breaking enhanced CI

now int to avoid possible string buffer overflow
@dmknutsen
Copy link
Contributor Author

dmknutsen commented Feb 25, 2020 via email

@astrogeco
Copy link
Contributor

CCB 20200226 - Approved
This might affect 16-bit architectures but cFS doesn't support them.

@astrogeco astrogeco added CCB - 20200226 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 26, 2020
@astrogeco astrogeco changed the base branch from master to ic-20200304 March 2, 2020 20:35
@astrogeco astrogeco merged commit 60af1f7 into nasa:ic-20200304 Mar 2, 2020
@astrogeco astrogeco mentioned this pull request Mar 10, 2020
@astrogeco astrogeco added this to the 6.8.0 milestone Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure of ut_time_stubs with BUILDTYPE=release
3 participants