IC 20200304 #544
Merged
IC 20200304 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate 20200304
Fixes #358, #487, and #498
See PRs #505, #504, and #500 for more info
Testing performed
Steps taken to test the contribution:
Expected behavior changes
#358 - No longer requires sed "hack" to change the setting in default_config.h
#487 - Clean build
#498 - None
System(s) tested on
CI
Additional context
See PRs #505, #504, and #500 for more info
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
Daniel Knutsen - NASA/GSFC
Gerardo E. Cruz-Ortiz - NASA/GSFC