Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #358, Add native permissive mode configuration #505

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 31, 2020

Describe the contribution
This adds the native_osconfig.h which is included after
the default_osconfig.h if SIMULATION=native is set.
Fix #358

Testing performed
Steps taken to test the contribution:

  1. copy cfe/cmake/sample_defs to top dir (per standard setup instructions)
  2. make SIMULATION=native prep
  3. make; make install;
  4. Execute core-cpu1 in build/exe/cpu1 and confirmed permissive mode
  5. Also did steps above with just make prep, and confirmed permissive mode wasn't set

Expected behavior changes
No longer requires sed "hack" to change the setting in default_config.h

System(s) tested on

  • Hardware: cFS Dev server 2
  • OS: Ubuntu 18.04
  • Versions: master bundle with this branch

Additional context
Update related README's and CI to no longer perform sed "hack"

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.8.0 milestone Jan 31, 2020
This adds the native_osconfig.h which is included after
the default_osconfig.h if SIMULATION=native is set.
@skliper skliper force-pushed the fix358-native-permissive-mode branch from e6851c4 to ea00d46 Compare January 31, 2020 15:12
@skliper
Copy link
Contributor Author

skliper commented Jan 31, 2020

Eliminated duplicate documentation of the define.

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 20, 2020
@astrogeco
Copy link
Contributor

CCB 20200226 - Approved

@astrogeco astrogeco added CCB - 20200226 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 26, 2020
@astrogeco astrogeco changed the base branch from master to ic-20200304 March 2, 2020 20:35
@astrogeco astrogeco merged commit eea202c into nasa:ic-20200304 Mar 2, 2020
@astrogeco astrogeco mentioned this pull request Mar 10, 2020
@skliper skliper deleted the fix358-native-permissive-mode branch February 1, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User/beginner friendly permissive mode implementation
2 participants