Merge pull request #129 from CDKnightNASA/fix-128-strncpy_null_term

Fix #128, strncpy should result in null term
nasa · Sep 3, 2020 · ec54b1a · ec54b1a
2 parents bafd03b + 446179d
commit ec54b1a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Subsystems/cmdUtil/cmdUtil.c b/Subsystems/cmdUtil/cmdUtil.c
@@ -814,7 +814,7 @@ int main(int argc, char *argv[])
                 }
 
                 /* Copy the data over (zero fills) */
-                strncpy(sbuf, &tail[1], sizeof(sbuf));
+                strncpy(sbuf, &tail[1], sizeof(sbuf) - 1);
                 CopyData(cmd.Packet, &startbyte, sbuf, tempull);
 
                 /* Reset tail so it doesn't trigger error */