Fix #128, strncpy should result in null term #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
changed the title
skliper
approved these changes
Sep 2, 2020
|
CCB 2020-09-02 APPROVED, fix parenthesis |
astrogeco
reviewed
Sep 2, 2020
CDKnightNASA
force-pushed
the
fix-128-strncpy_null_term
branch
from
da440e7
to
446179d
Compare
skliper
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Closes #128
Reduce the size of the strncpy so that it ensures there's a null byte at the end of the string buffer.
Testing performed
make install, make test
System(s) tested on
Debian 10.5
Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov