Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #593, Add Category to Cppcheck Workflow #594

Merged

Conversation

ArielSAdamsNASA
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes #593

Testing performed
Made changes to cFS fork and test on PSP fork.

image

Expected behavior changes
Same behavior. Added category so second SARIF file upload does not fail.

Additional context
Workflow may fail due to ubuntu being out of date. GitHub will now throw brownouts for out of date ubuntu versions.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, MCSG Tech

@ArielSAdamsNASA ArielSAdamsNASA added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) continuous-integration labels Oct 14, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Oct 20, 2022

CCB 20 October 2022: Approved pending confirmation Ubuntu workflow updates resolve failing checks.

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 20, 2022
dzbaker added a commit that referenced this pull request Oct 26, 2022
*Combines:*

cfe v7.0.0-rc4+dev201
osal v6.0.0-rc4+dev147

**Includes:**

*cFS*
- #594
- #559

*cFE*
- nasa/cFE#2184

*osal*
- nasa/osal#1319

Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Oct 26, 2022
2 tasks
dzbaker added a commit that referenced this pull request Oct 26, 2022
*Combines:*

cfe v7.0.0-rc4+dev201
osal v6.0.0-rc4+dev147

**Includes:**

*cFS*
- #594
- #559

*cFE*
- nasa/cFE#2184

*osal*
- nasa/osal#1319

Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
@dzbaker dzbaker merged commit 4590bbd into nasa:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB continuous-integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static Analysis Failing on Second SARIF Upload
3 participants