Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using FcnCode (instead of CommandCode) terminology in the code #127

Closed
2 tasks done
thnkslprpt opened this issue Oct 19, 2022 · 0 comments · Fixed by #128
Closed
2 tasks done

Recommend using FcnCode (instead of CommandCode) terminology in the code #127

thnkslprpt opened this issue Oct 19, 2022 · 0 comments · Fixed by #128

Comments

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Oct 19, 2022

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Copy of nasa/sample_app#167

Expected behavior
Rename the CommandCode variable in CI_LAB_ProcessGroundCommand() to FcnCode to better align with the cFE API.

Code snips

ci_lab/fsw/src/ci_lab_app.c

Lines 225 to 232 in a5e8b4b

void CI_LAB_ProcessGroundCommand(CFE_SB_Buffer_t *SBBufPtr)
{
CFE_MSG_FcnCode_t CommandCode = 0;
CFE_MSG_GetFcnCode(&SBBufPtr->Msg, &CommandCode);
/* Process "known" CI task ground commands */
switch (CommandCode)

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/ci_lab that referenced this issue Oct 19, 2022
thnkslprpt added a commit to thnkslprpt/ci_lab that referenced this issue Nov 1, 2023
dmknutsen added a commit that referenced this issue Nov 8, 2023
…riable

Fix #127, Rename CommandCode variable to FcnCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant