Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend using FcnCode (instead of CommandCode) terminology in the code #167

Closed
SpaceSteve121 opened this issue Mar 10, 2022 · 1 comment · Fixed by #187
Closed

Recommend using FcnCode (instead of CommandCode) terminology in the code #167

SpaceSteve121 opened this issue Mar 10, 2022 · 1 comment · Fixed by #187
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@SpaceSteve121
Copy link

The current implementation of the sample app mixes terminology, calling the field which identifies a command a CommandCode whereas the CFE APIs call it a FcnCode.

Since this app is the starting point for many people, it might make sense to use consistent terminology. Since the CFE APIs call it a FcnCode, it seems like the code should too.
@SpaceSteve121 SpaceSteve121 added the good first issue Good for newcomers label Mar 10, 2022
@skliper skliper added the enhancement New feature or request label Mar 10, 2022
@thnkslprpt
Copy link
Contributor

Note the same issue occurs in to_lab and ci_lab (I assume the functions were copied from one to the other when these lab apps were created, with the relevant adaptations being made).
Screenshot 2022-10-19 10 15 30

This was referenced Oct 19, 2022
Merged
Open
Closed
dzbaker added a commit that referenced this issue Nov 13, 2023
@dzbaker
Merge pull request #187 from thnkslprpt:fix-167-rename-commandcode-va…
294e13c 
…riable

Fix #167, Rename CommandCode variable to FcnCode
@dzbaker dzbaker mentioned this issue Nov 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #167, Rename CommandCode variable to FcnCode thnkslprpt/sample_app
3 participants
@thnkslprpt @SpaceSteve121 @skliper