Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Return Value of chmod #86

Closed
ArielSAdamsNASA opened this issue Sep 27, 2021 · 0 comments · Fixed by #124
Closed

Check Return Value of chmod #86

ArielSAdamsNASA opened this issue Sep 27, 2021 · 0 comments · Fixed by #124

Comments

@ArielSAdamsNASA
Copy link

Describe the bug
Calling chmod(DstFilename, dststat.st_mode & 0xffffffc0U) without checking return value. This library function may fail and return an error code.

Expected behavior
Check the return value of chmod.

Code snips

elf2cfetbl/elf2cfetbl.c

Line 1460 in 10f55fb

chmod(DstFilename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info
Ariel Adams, ASRC Federal
thnkslprpt added a commit to thnkslprpt/elf2cfetbl that referenced this issue Nov 12, 2022
@thnkslprpt
Fix nasa#86, Check return value from chmod
6b86057
thnkslprpt added a commit to thnkslprpt/elf2cfetbl that referenced this issue Nov 12, 2022
@thnkslprpt
Fix nasa#86, Check return value from chmod
fe57a1b
@thnkslprpt thnkslprpt mentioned this issue Nov 12, 2022
Merged
2 tasks
dzbaker added a commit that referenced this issue Jul 2, 2024
@dzbaker
Merge pull request #124 from thnkslprpt:fix-86-check-chmod-return
2c10360 
Fix #86, Check return from chmod
@dzbaker dzbaker mentioned this issue Jul 2, 2024
Merged
2 tasks
@dzbaker dzbaker closed this as completed in 935a55d Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #86, Check return from chmod thnkslprpt/elf2cfetbl
1 participant
@ArielSAdamsNASA