elf2cfetbl Integration candidate: Equuleus-rc1+dev13 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate the value from the CMake scripts into the generated tbl files. This utilizes existing command line options on elf2cfetbl, just passing the values through via the scripts.
Fix #146, Include PRID and SCID in table files
Fix #86, Check return from chmod
…stat Fix #87, Check return value of stat()
…d-function Fix #126, Move variables declared mid-function to the top
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return FAILED; | ||
| } | ||
|
|
||
| if (stat(DstFilename, &dststat) != 0) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
elf2cfetbl Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 18.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt
@jphickey