Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysconf can return -1 on error #569

Closed
ghost opened this issue Aug 20, 2020 · 0 comments · Fixed by #682 or #690
Closed

sysconf can return -1 on error #569

ghost opened this issue Aug 20, 2020 · 0 comments · Fixed by #682 or #690
Labels
bug
Milestone
Caelum

Comments

@ghost
Copy link

ghost commented Aug 20, 2020

in posix/src/os-impl-tasks.c sysconf() is used. Its storage is into a type size_t, but sysconf() can return -1. We should change the storage to ssize_t to accommodate this, or we should check for -1 and then store a non-negative value to POSIX_GlobalVars.PageSize. sysconf() shouldn't return -1 when passed _SC_PAGESIZE, so this may be low priority.
skliper added a commit to skliper/osal that referenced this issue Dec 9, 2020
@skliper
Fix nasa#569, Check and report sysconf error return
4b56ac1
@skliper skliper mentioned this issue Dec 9, 2020
Merged
@skliper skliper added this to the 6.0.0 milestone Dec 9, 2020
@astrogeco astrogeco added bug and removed enhancement labels Dec 18, 2020
astrogeco added a commit that referenced this issue Dec 18, 2020
@astrogeco
Merge pull request #682 from skliper/fix569-neg_sysconf
7586872 
Fix #569, Check and report sysconf error return
@astrogeco astrogeco mentioned this issue Dec 18, 2020
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#569, Resolve CI warnings and add badge
9e226c2
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#570 from skliper/fix569-ci-warn-badge
a77db2b 
Fix nasa#569, Resolve CI warnings and add badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco