Fix #569, Check and report sysconf error return #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
astrogeco
added
CCB-20201216
and removed
CCB:Ready
|
CCB 2020-12-16 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #569 - Checks return of sysconf for error and if so reports, only sets PageSize on success.
Testing performed
Build and run unit tests
Expected behavior changes
None since sysconf should never fail, but if it does provides mechanism to avoid error propagation
System(s) tested on
Additional context
None.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC