Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTEMS build broken #615

Closed
jphickey opened this issue Oct 2, 2020 · 0 comments · Fixed by #612
Closed

RTEMS build broken #615

jphickey opened this issue Oct 2, 2020 · 0 comments · Fixed by #612
Assignees
@jphickey
Labels
bug
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Oct 2, 2020

Describe the bug
Needs updates to fix issues related to OS_Milli2Ticks

  • Missing prototype
  • References to old function prototype still exist in some RTEMS source files.

To Reproduce
Build default configuration for RTEMS 4.11. Fails to compile with errors such as:

/home/joe/code/cfecfs/github/osal/src/os/rtems/src/os-impl-countsem.c: In function 'OS_CountSemTimedWait_Impl':
/home/joe/code/cfecfs/github/osal/src/os/rtems/src/os-impl-countsem.c:212:5: error: implicit declaration of function 'OS_Milli2Ticks' [-Werror=implicit-function-declaration]
     TimeInTicks = OS_Milli2Ticks(msecs);
     ^

Expected behavior
Should compile cleanly.

System observed on:
Ubuntu 20.04 (host) cross buiding for RTEMS 4.11.3 / pc-686 BSP

Additional context
Typo noted in #614 but there are more problems than just that....

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 2, 2020
@jphickey jphickey added the bug label Oct 2, 2020
jphickey added a commit to jphickey/osal that referenced this issue Oct 2, 2020
@jphickey
Fix nasa#615, RTEMS build issues
cd1e468 
Correct issues involving recent OS_Milli2Ticks change.

Note - for OS_TaskDelay it is important that this doesn't degrade
into a no-op.  So if OS_Milli2Ticks fails here, this returns the
error but still also does a non-zero delay.
@jphickey jphickey mentioned this issue Oct 2, 2020
Closed
astrogeco added a commit that referenced this issue Oct 5, 2020
@astrogeco
Merge pull request #616 from jphickey/fix-615-rtems-build
9f0975c 
Fix #615, RTEMS build issues
@astrogeco astrogeco mentioned this issue Oct 5, 2020
Merged
@astrogeco astrogeco added this to the 6.0.0 milestone Oct 6, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#615 from nasa/integration-candidate
0648a47 
Integration Candidate 2020-04-08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Integration Candidate: 2020-10-07 nasa/osal
2 participants
@jphickey @astrogeco