Integration Candidate: 2020-04-15 #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #354, Shell related API separated for optional implementation
The OSAL_SYSTEM_BSPTYPE specification by itself is enough to build OSAL, as it implies a specific OS layer. However, if OSAL_SYSTEM_OSTYPE is explicitly specified, it is used, but will generate a warning if it is different than the OS layer implied by the BSP, as there could be reasons for doing this during development.
Never fully implemented and more appropriate in PSP layer due to platform dependencies
Fix #366, Deprecated exception handling APIs
Fix #432, Infer OSAL_SYSTEM_OSTYPE from OSAL_SYSTEM_BSPTYPE
This was
linked to
issues
Apr 27, 2020
Closed
OS_SelectFdZero/OS_SelectFdAdd/OS_SelectFdClear/OS_SelectFdIsSet does not ensure Set is != NULL
#390
Closed
Closed
astrogeco
force-pushed
the
integration-candidate
branch
from
944925f
to
2250a38
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
2250a38
to
1b36816
Compare
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#433, Release Prep Document and copyright header changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #413, #88, #12, #390, #392, #407, #368, #366, #354, and #432
Testing performed
See PRs
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/162280689
Expected behavior changes
Updated comments related to sizing includes null terminator for:
OS_MAX_API_NAME, OS_MAX_PATH_LEN, OS_BUFFER_SIZE
Added debug message if microsecs per sec value does not equal 1000000.
OSAL_SYSTEM_BSPTYPEis set (not OSAL_SYSTEM_OSTYPE). Generates a warning whenOSAL_SYSTEM_BSPTYPEandOSAL_SYSTEM_OSTYPEare both set but are mismatched. Confirmed this works by intentionally mismatching in a config.System(s) tested on
Additional context
Part of nasa/cFS#70
Contributor Info - All information REQUIRED for consideration of pull request
Chris D. Knight, NASA-ARC
Leor Bleir, NASA-GSFC
Daniel Knutsen, NASA-GSFC
Jacob Hageman, NASA-GSFC
Joseph Hickey, Vantage Systems, Inc.