Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply #585 to Bootes, Set Revision to 99 for development build #587

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Sep 1, 2020

Describe the contribution
Fix #584 for Bootes

Testing performed
Built and ran locally based on bundle tag for bootes-rc1
Built in CI, See https://travis-ci.com/github/astrogeco/cFS/builds/189834136

Expected behavior changes
Revision version number now reports 99 during development versions. ES Housekeeping data reports 5.0.99 in the version string.

System(s) tested on
Built and ran on Docker container.

Additional context
Approved for main branch in #585
Also see nasa/cFE#830

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz, NASA-GSFC

The version number macros major, minor, and revision, are used in the HK telemetry which can lead to confusion.
@astrogeco astrogeco changed the base branch from main to 5.1.x September 1, 2020 19:33
@skliper skliper marked this pull request as draft September 21, 2020 18:49
@skliper
Copy link
Contributor

skliper commented Sep 21, 2020

Doesn't look ready. Converting to draft. @astrogeco - do you have an estimate on when this will be ready?

astrogeco added a commit to astrogeco/cFS that referenced this pull request Oct 13, 2020
@astrogeco astrogeco marked this pull request as ready for review October 13, 2020 22:35
@astrogeco astrogeco added this to the v5.1.0 milestone Oct 13, 2020
@astrogeco astrogeco merged commit 00dc94d into nasa:5.1.x Oct 13, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Oct 14, 2020
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
 nasa#787
 - cES1005.1: Remove application load address from start app command
 - cTBL6003.1: Clarify table validation pior to activate
 - cEVS3103.4, cEVS3103.5, cEVS3001: Remove SB qualifier
 nasa#587
 - cSB4344: Added get packet type API requirement
 - cSB4345: Added message ID validation API requirement
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants