Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tblCRCTool needs a CMakeLists.txt file implemented #10

Closed
jphickey opened this issue Sep 13, 2019 · 2 comments
Closed

tblCRCTool needs a CMakeLists.txt file implemented #10

jphickey opened this issue Sep 13, 2019 · 2 comments
Milestone
Aquila

Comments

@jphickey
Copy link
Contributor

Describe the bug
This tool is not built like the rest of them, still using a one-off Makefile.

To Reproduce
Build CFE using the recommended CMake practice. This tool is not built. The user must then manually build the tool within the source directory.

Expected behavior
The tool should be built as part of the overall mission build and installed to the "host" directory.

System observed on:
Ubuntu 18.04 (64-bit)

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey mentioned this issue Sep 13, 2019
Closed
@skliper
Copy link
Contributor

skliper commented Sep 13, 2019

Need to confirm original makefile gets removed so there is no chance of getting a cfe_ts_crc in this directory.

jphickey added a commit to jphickey/tblCRCTool that referenced this issue Sep 13, 2019
@jphickey
Add a CMakeLists.txt file for the tblCRCTool
2ad807f 
This allows it to be tied into the main CFE mission build
and correctly reference the same header files as the FSW does.

Fixes nasa#10
@jphickey jphickey mentioned this issue Sep 13, 2019
Closed
@skliper
Copy link
Contributor

skliper commented Sep 13, 2019

Need to confirm original makefile gets removed so there is no chance of getting a cfe_ts_crc in this directory.

Confirmed.

@skliper skliper mentioned this issue Sep 13, 2019
Closed
skliper added a commit that referenced this issue Sep 16, 2019
@skliper
FASTTRACK: Merge #1 #2 #10
b2955a7 
Fasttracked to test
@skliper skliper mentioned this issue Sep 16, 2019
Closed
skliper added a commit that referenced this issue Sep 16, 2019
@skliper
FASTTRACK: Merge #1 #2 #10
7177ffc 
Fasttracked to test
@skliper skliper added this to the 1.1.0 milestone Sep 16, 2019
@skliper skliper closed this as completed in aa0c449 Oct 1, 2019
skliper added a commit that referenced this issue Oct 1, 2019
@skliper
FASTTRACK: Merge #1 #2 #10
f91d253 
Fasttracked to test, reviewed at 2019-09-25 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aquila
2 participants
@jphickey @skliper