Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tblCRCTool build warnings #2

Closed
skliper opened this issue Jun 24, 2019 · 4 comments
Closed

tblCRCTool build warnings #2

skliper opened this issue Jun 24, 2019 · 4 comments
Assignees
@avan989
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Aquila

Comments

@skliper
Copy link
Contributor

skliper commented Jun 24, 2019

The tblCRCTool had build warnings (using CentOS 6). Easy fix.
Adding

#include <stdlib.h>

fixed it.
Also the Makefile has the wrong include directory (should be "-I.") and it breaks if make clean is already run (need "rm -f").
@skliper skliper added the bug Something isn't working label Jun 24, 2019
@skliper skliper added this to the 1.1.0 milestone Jun 24, 2019
@skliper skliper added the good first issue Good for newcomers label Jun 24, 2019
@avan989
Copy link

avan989 commented Aug 29, 2019

I can do this.

skliper added a commit that referenced this issue Sep 10, 2019
@skliper
Merge pull request #6 from avan989/buildWarning
235d5df 
Fix #2, Build Warning
skliper pushed a commit that referenced this issue Sep 10, 2019
@avan989 @skliper
Fix #2, Resolve build warnings
57ab445
skliper added a commit that referenced this issue Sep 10, 2019
@skliper
CCB 2019-09-04: Merge #1 #2 #3
950cced 
Reviewed and approved at 2019-09-04 CCB
skliper added a commit that referenced this issue Sep 10, 2019
@skliper
CCB 2019-09-04: Merge #1 #2 #3
f3b3c93 
Reviewed and approved at 2019-09-04 CCB
@skliper skliper mentioned this issue Sep 10, 2019
Closed
@jphickey
Copy link
Contributor

Note that the commit that says it fixes this (57ab445) seems mislabeled. That commit only adds an "-f" switch for the clean target. It looks like the commit for #1 (6ed9db2) is the one that actually addresses this?

@skliper
Copy link
Contributor Author

skliper commented Sep 12, 2019

Yeah, #6 notes the first issue in the ticket was fixed in commit #1, this does fix the second part of this issue though.

@jphickey
Copy link
Contributor

OK -- I was just confused as I was looking at the individual changes in the ic branch that didn't seem to line up. No problem as it is just a trivial change.

skliper pushed a commit that referenced this issue Sep 12, 2019
@avan989 @skliper
Fix #2, Resolve build warnings
66d67e4
skliper added a commit that referenced this issue Sep 12, 2019
@skliper
CCB 2019-09-04: Merge #1 #2
db26fa9 
Reviewed and approved at 2019-09-04 CCB
skliper added a commit that referenced this issue Sep 12, 2019
@skliper
Fix #2, Include path and rm -f
7f398c4
skliper added a commit that referenced this issue Sep 12, 2019
@skliper
CCB 2019-09-04: Merge #1 #2
cc6950b 
Reviewed and approved at 2019-09-04 CCB
skliper added a commit that referenced this issue Sep 16, 2019
@skliper
Fix #1, fix #2: Close file, add includes
13ce8bd
skliper added a commit that referenced this issue Sep 16, 2019
@skliper
FASTTRACK: Merge #1 #2 #10
b2955a7 
Fasttracked to test
@skliper skliper mentioned this issue Sep 16, 2019
Closed
skliper added a commit that referenced this issue Sep 16, 2019
@skliper
FASTTRACK: Merge #1 #2 #10
7177ffc 
Fasttracked to test
@skliper skliper closed this as completed in d995f5e Oct 1, 2019
skliper added a commit that referenced this issue Oct 1, 2019
@skliper
FASTTRACK: Merge #1 #2 #10
f91d253 
Fasttracked to test, reviewed at 2019-09-25 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avan989 avan989

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Aquila
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20190906 nasa/tblCRCTool
Integration candidate 20190916 nasa/tblCRCTool
3 participants
@jphickey @avan989 @skliper