Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TO_LAB should better follow cmd/tlm patterns in other modules #22

Closed
jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #24 or #27
Closed

TO_LAB should better follow cmd/tlm patterns in other modules #22

jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #24 or #27

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 7, 2020

Is your feature request related to a problem? Please describe.
The TO_LAB implementation currently does not adhere to the command/telemetry processing patterns established in CFE core and other modules.

Describe the solution you'd like

  • Each command handler should be its own function with its own distinct structure type that is passed in to it
  • Housekeeping should put its payload into a separate sub-structure called "Payload"
  • Telemetry/Command naming conventions documented in CFE should be adhered to

Additional context
Part of the reason for some of these patterns is they help future-proof the code and also help avoid issues like #21.

Requester Info
Joseph Hickey, Vantage Systems Inc.
jphickey added a commit to jphickey/to_lab that referenced this issue Feb 7, 2020
@jphickey
Fix nasa#22: Cleanup naming of command and telemetry
a66df71 
Follow the naming conventions in the CFE naming convention document
and follow message processing patterns from other modules.

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
@jphickey jphickey mentioned this issue Feb 7, 2020
Merged
jphickey added a commit to jphickey/to_lab that referenced this issue Feb 11, 2020
@jphickey
Merge nasa#15, nasa#22, nasa#23 into EDS baseline
ab21514 
This reflects general issues/patches to the upstream repository that
need to be resolved for EDS support
jphickey added a commit to jphickey/to_lab that referenced this issue Mar 2, 2020
@jphickey
Fix nasa#22: Cleanup naming of command and telemetry
199c60d 
Follow the naming conventions in the CFE naming convention document
and follow message processing patterns from other modules.

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
astrogeco pushed a commit that referenced this issue Mar 9, 2020
@jphickey @astrogeco
Fix #22: Cleanup naming of command and telemetry
e033dcf 
Follow the naming conventions in the CFE naming convention document
and follow message processing patterns from other modules.

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
@astrogeco astrogeco mentioned this issue Mar 10, 2020
Merged
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
IC 20200304 #27
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple cleanup items for TO_LAB jphickey/to_lab
IC 20200304 nasa/to_lab
1 participant
@jphickey