Multiple cleanup items for TO_LAB #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This pull request is also likely to fix #21 as well (need to test separately) |
|
Confirmed this fixes #21 - to_lab builds cleanly on Raspberry Pi. |
Integration Candidate 20200226
Change TO_LAB to use the OSAL socket API rather than calling BSD sockets functions directly.
This creates a TO_LAB_Global namespace to isolate these global variables from other modules and prevent collision.
Follow the naming conventions in the CFE naming convention document and follow message processing patterns from other modules. - Separate each command into a separate handler function - Each command handler accepts a const pointer to the full message - Put Telemetry payload into a separate "Payload" sub-structure
jphickey
force-pushed
the
fix-15-22-23-to_lab-cleanup
branch
from
a66df71
to
199c60d
Compare
|
NOTE: rebased to updated master (2020226 baseline) and resolved conflicts. |
skliper
approved these changes
Mar 2, 2020
skliper
added
the
CCB:Ready
astrogeco
added
IC - 20200226
CCB:Approved
|
CCB Fast Tracked - Reviewed by J. Hageman |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Cleans up multiple aspects of the TO_LAB implementation. Details Below.
Fixes #15
Fixes #22
Fixes #23
These change sets are submitted as a single pull request, as they have inter-dependencies between them and will trigger conflicts if presented individually. This pull request still contains each fix as an individual commit, so each one can be independently reviewed.
For #15 / commit 17180f0: Change TO_LAB to use the OSAL socket API rather than calling BSD sockets functions directly.
For #23 / commit d041045: This creates a TO_LAB_Global namespace to isolate these global variables from other modules and prevent collision
For #22 / commit a66df71: Follow the naming conventions in the CFE naming convention document and follow message processing patterns from other modules
Testing performed
Build for native for both debug/release builds, with unit tests enabled. Confirmed normal operation of TO_LAB using the Python cFS_GroundSystem tool to enable telemetry output and verify that telemetry is being received as normal.
Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 18.04 LTS, 64 bit
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.