Fix warning message for implicitly supporting turn_on/off methods in HVACModes #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HVACModes Entity None (<class 'custom_components.vivint.climate.VivintClimate'>) implements HVACMode(s): cool, heat, heat_cool, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/natekspencer/hacs-vivint/issues
natekspencer
requested changes
Dec 19, 2024
custom_components/vivint/climate.py
Outdated
| ) | ||
| _enable_turn_on_off_backwards_compatibility = False |
There was a problem hiding this comment.
Move this so it is under all _attr_* settings
custom_components/vivint/climate.py
Outdated
| @@ -209,12 +212,21 @@ async def async_set_fan_mode(self, fan_mode: str) -> None: | |||
| } | |||
| ) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Get rid of this extra line break
Move _enable_turn_on_off_backwards_compatibility after all _attr_* settings. Remove extra link break.
natekspencer
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161: Warning message:
Entity None (<class 'custom_components.vivint.climate.VivintClimate'>) implements HVACMode(s): cool, heat, heat_cool, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/natekspencer/hacs-vivint/issues