Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning message for implicitly supporting turn_on/off methods in HVACModes #162

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix warning message for implicitly supporting turn_on/off methods in HVACModes #162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9189cc4
Fix warning message for implicitly supporting turn_on/off methods in …
kitprice Dec 18, 2024
18302d5
Cosmetic changes
kitprice Dec 19, 2024
587d356
Merge branch 'natekspencer:main' into kitprice-patch-warning
kitprice Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions custom_components/vivint/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,11 @@ class VivintClimate(VivintEntity, ClimateEntity):
ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.TARGET_TEMPERATURE_RANGE
| ClimateEntityFeature.FAN_MODE
| ClimateEntityFeature.TURN_ON
| ClimateEntityFeature.TURN_OFF
)
_attr_temperature_unit = UnitOfTemperature.CELSIUS
_enable_turn_on_off_backwards_compatibility = False

def __init__(self, device: Thermostat, hub: VivintHub) -> None:
"""Pass coordinator to CoordinatorEntity."""
Expand Down Expand Up @@ -216,6 +219,14 @@ async def async_set_hvac_mode(self, hvac_mode: str) -> None:
**{ThermostatAttribute.OPERATING_MODE: VIVINT_HVAC_INV_MODE_MAP[hvac_mode]}
)

async def async_turn_on(self) -> None:
"""Turn the entity on."""
await self.async_set_hvac_mode(HVACMode.HEAT_COOL)

async def async_turn_off(self) -> None:
"""Turn the entity off."""
await self.async_set_hvac_mode(HVACMode.OFF)

async def async_set_temperature(self, **kwargs: Any) -> None:
"""Set new target temperature."""
temp = kwargs.get(ATTR_TEMPERATURE)
Expand Down
Loading