Skip to content

Commit

Permalink
De-flake TestNoRaceJetStreamClusterGhostConsumers (#5961)
Browse files Browse the repository at this point in the history
Both tests became a bit flaky. If they would not be able to retry within
the first 5s, the test would fail. So having CI be a bit slow could make
this flake.

Lowering the `startInterval` for these tests to more often try to run
the consumer cleanup.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
  • Loading branch information
derekcollison authored Oct 4, 2024
2 parents acbca0f + 6e20f62 commit 0ee33a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion server/jetstream_cluster_3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1600,7 +1600,7 @@ func TestJetStreamClusterParallelConsumerCreation(t *testing.T) {
}

func TestJetStreamClusterGhostEphemeralsAfterRestart(t *testing.T) {
consumerNotActiveStartInterval = time.Second * 5
consumerNotActiveStartInterval = time.Second
defer func() {
consumerNotActiveStartInterval = defaultConsumerNotActiveStartInterval
}()
Expand Down
2 changes: 1 addition & 1 deletion server/norace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6577,7 +6577,7 @@ func TestNoRaceJetStreamConsumerCreateTimeNumPending(t *testing.T) {
}

func TestNoRaceJetStreamClusterGhostConsumers(t *testing.T) {
consumerNotActiveStartInterval = time.Second * 5
consumerNotActiveStartInterval = time.Second
defer func() {
consumerNotActiveStartInterval = defaultConsumerNotActiveStartInterval
}()
Expand Down

0 comments on commit 0ee33a2

Please sign in to comment.