Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake TestNoRaceJetStreamClusterGhostConsumers #5961

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

MauriceVanVeen
Copy link
Member

Both tests became a bit flaky. If they would not be able to retry within the first 5s, the test would fail. So having CI be a bit slow could make this flake.

Lowering the startInterval for these tests to more often try to run the consumer cleanup.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen marked this pull request as ready for review October 4, 2024 12:56
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner October 4, 2024 12:56
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 0ee33a2 into main Oct 4, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/deflake-js-ghost-consumers branch October 4, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants