Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST only] removed some flakier test of TestXMQTT #5580

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

levb
Copy link
Contributor

@levb levb commented Jun 21, 2024

Removed leaf-node related TestXMQTTRetained... test cases, they were too flaky.

@levb levb requested a review from a team as a code owner June 21, 2024 20:07
@levb
Copy link
Contributor Author

levb commented Jun 21, 2024

The relevant job succeeded in 4f230b5 with a 50 repeat count

server/mqtt_ex_test_test.go Outdated Show resolved Hide resolved
@derekcollison derekcollison self-requested a review June 21, 2024 20:14
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 063fac4 into main Jun 21, 2024
1 of 3 checks passed
@derekcollison derekcollison deleted the lev-mqttex-tmpfix branch June 21, 2024 20:14
wallyqs pushed a commit that referenced this pull request Jun 21, 2024
Removed leaf-node related `TestXMQTTRetained...` test cases, they were
too flaky.
wallyqs added a commit that referenced this pull request Jun 21, 2024
Includes:

* #5571 
* #5082
* #5573
* #5574
* #5575
* #5577
* #5578
* #5580 
* #5559 

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants