Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST only] removed some flakier test of TestXMQTT #5580

Merged
merged 5 commits into from
Jun 21, 2024
Merged

[TEST only] removed some flakier test of TestXMQTT #5580

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93aa490
[TEST only] removed some flakier test of TestXMQTT
levb Jun 21, 2024
c8bdf05
run on push to test
levb Jun 21, 2024
4f230b5
more retries to see if flakes
levb Jun 21, 2024
b7e4682
restored the GH job to what it was
levb Jun 21, 2024
51d4956
removed commented out tests
levb Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions server/mqtt_ex_test_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,30 +79,30 @@ func TestXMQTTRetainedMessages(t *testing.T) {
name: "single server",
makef: mqttMakeTestServer,
},
{
name: "server with leafnode",
makef: mqttMakeTestServerWithLeafnode("HUBD", "LEAFD", true),
},
{
name: "server with leafnode no domains",
makef: mqttMakeTestServerWithLeafnode("", "", true),
},
{
name: "server with leafnode no system account",
makef: mqttMakeTestServerWithLeafnode("HUBD", "LEAFD", false),
},
// {
derekcollison marked this conversation as resolved.
Show resolved Hide resolved
// name: "server with leafnode",
// makef: mqttMakeTestServerWithLeafnode("HUBD", "LEAFD", true),
// },
// {
// name: "server with leafnode no domains",
// makef: mqttMakeTestServerWithLeafnode("", "", true),
// },
// {
// name: "server with leafnode no system account",
// makef: mqttMakeTestServerWithLeafnode("HUBD", "LEAFD", false),
// },
{
name: "cluster",
makef: mqttMakeTestCluster(4, ""),
},
{
name: "cluster with leafnode cluster",
makef: mqttMakeTestClusterWithLeafnodeCluster("HUBD", "LEAFD", true),
},
{
name: "cluster with leafnode cluster no system account",
makef: mqttMakeTestClusterWithLeafnodeCluster("HUBD", "LEAFD", false),
},
// {
// name: "cluster with leafnode cluster",
// makef: mqttMakeTestClusterWithLeafnodeCluster("HUBD", "LEAFD", true),
// },
// {
// name: "cluster with leafnode cluster no system account",
// makef: mqttMakeTestClusterWithLeafnodeCluster("HUBD", "LEAFD", false),
// },
} {
t.Run(topo.name, func(t *testing.T) {
target := topo.makef(t)
Expand Down