Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] More protection against stree being nil #5662

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

derekcollison
Copy link
Member

There are cases in filestore where errors can leave an stree nil. We report those errors but do not terminate all executions so this protects us generally from the stree being nil.

Resolves: #5656

Signed-off-by: Derek Collison derek@nats.io

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner July 16, 2024 18:41
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit ddfce5f into main Jul 16, 2024
5 checks passed
@derekcollison derekcollison deleted the stree-panic branch July 16, 2024 20:51
wallyqs added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic nil pointer dereference
3 participants