Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Prevent a server from panicking when shutdown immediately after starting. #5663

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[FIXED] Prevent a server from panicking when shutdown immediately after starting. #5663

merged 1 commit into from
Jul 16, 2024

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Prevent a server from panicking when the server is shutdown while we …
63b0bb3 
…are initializing eventing.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner July 16, 2024 18:54
wallyqs
wallyqs approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 702640c into main Jul 16, 2024
5 checks passed
@derekcollison derekcollison deleted the event-panic branch July 16, 2024 20:51
@wallyqs wallyqs mentioned this pull request Jul 16, 2024
Merged
wallyqs added a commit that referenced this pull request Jul 16, 2024
@wallyqs
Cherry-picks for 2.10.18-RC.4 (#5664)
ff36cf0 
Includes:

- #5662
- #5663
- #5660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekcollison @wallyqs