[FIXED] New staticcheck fixes #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
server/stree/node48.go:72:21: every value of type byte is <= math.MaxUint8 (SA4003) Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
approved these changes
Aug 25, 2024
|
@neilalexander would need official LGTM from you or @wallyqs |
wallyqs
pushed a commit
that referenced
this pull request
Aug 26, 2024
@neilalexander I do believe this uncovered two off by one conditions in node48 under stree. Could you take a look, kept that change separate. --------- Signed-off-by: Derek Collison <derek@nats.io> Signed-off-by: Neil Twigg <neil@nats.io> Co-authored-by: Neil Twigg <neil@nats.io>
Jarema
pushed a commit
that referenced
this pull request
Aug 26, 2024
@neilalexander I do believe this uncovered two off by one conditions in node48 under stree. Could you take a look, kept that change separate. --------- Signed-off-by: Derek Collison <derek@nats.io> Signed-off-by: Neil Twigg <neil@nats.io> Co-authored-by: Neil Twigg <neil@nats.io>
wallyqs
added a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neilalexander I do believe this uncovered two off by one conditions in node48 under stree. Could you take a look, kept that change separate.