Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] New staticcheck fixes #5826

Merged
merged 3 commits into from
Aug 25, 2024
Merged

[FIXED] New staticcheck fixes #5826

merged 3 commits into from
Aug 25, 2024

Commits on Aug 25, 2024

  1. Updates for new staticcheck warnings 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    90dfa35 View commit details
    Browse the repository at this point in the history

  2. Had a staticcheck warning that surfaced 2 off by one conditions. 

    server/stree/node48.go:72:21: every value of type byte is <= math.MaxUint8 (SA4003)

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    71dbb14 View commit details
    Browse the repository at this point in the history

  3. Extend TestSubjectTreeNode48 to check for off-by-one 

    Signed-off-by: Neil Twigg <neil@nats.io>
    @neilalexander
    neilalexander committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    1368f68 View commit details
    Browse the repository at this point in the history