Remove server version validation #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Checking server version is not a reliable way to know if given API call is supported for given context, as client might be connected to a leaf node, while the meta leader is a different version, part of different cluster. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
When retry on initial connect was used, some JetStream consumer calls could panic in specific conditions because server version was not available. This test makes sure it will no longer happen. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
remove-server-version-validation
branch
from
6bc6636
to
ddb2184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If client was created with
retry_on_initial_connectandcreate_consumer_on_streamwas called immediately afterwards, it could cause a panic, as semver regex capture would fail on empty string.This PR removes the validation, as it was never a reliable way to check server version, as the meta leader can be a different version than the server that the client is connected to.
It also protects the server check method against empty semver string.
fixes #1271
Signed-off-by: Tomasz Pietrek tomasz@nats.io