Remove server version validation #1273
Merged
Commits on May 27, 2024
-
Protect
is_server_compatibleagainst empty versionSigned-off-by: Tomasz Pietrek <tomasz@nats.io>
-
Remove check for server compatibility from consumer create
Checking server version is not a reliable way to know if given API call is supported for given context, as client might be connected to a leaf node, while the meta leader is a different version, part of different cluster. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
-
When retry on initial connect was used, some JetStream consumer calls could panic in specific conditions because server version was not available. This test makes sure it will no longer happen. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.