Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

somewhat more detailed error messages #89

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

dominykas
Copy link
Contributor

With 2.0.3 I started seeing a lot of unknown in my error logs - that's not good, as it's really tricky to filter these errors out, so I changed the messages to, um, include more words :)

Speaking of 2.0.3 - how come npm has it, but the master here is still 2.0.1?

@naugtur
Copy link
Owner

naugtur commented Jul 28, 2015

2.0.3 is here, I didn't see that a push failed (probably made a typo in key password)

Your change also seems to cover for #88
I'll look into it soon.

@dominykas
Copy link
Contributor Author

Rebased to latest

@naugtur
Copy link
Owner

naugtur commented Aug 28, 2015

https://github.com/Raynos/xhr/pull/89/files#diff-168726dbe96b3ce427e7fedce31bb0bcR156 is great, I'm a bit worried about changing the existing error message.

But I'll merge it soon.
Anyone wants to comment?

@mattdesl
Copy link

mattdesl commented Sep 1, 2015

I am 👍 on this, the error message "unknown" doesn't really tell us much.

@dmlap
Copy link
Contributor

dmlap commented Sep 3, 2015

Any chance timeouts could also be indicated in a way that's easy to distinguish programmatically? I never finished putting together use-cases for #88 but it's still an important situation to recognize for us. I could parse it out of the error message after this PR but that seems like abusing the API a bit to me.

@naugtur
Copy link
Owner

naugtur commented Sep 7, 2015

I'm on vacation (and have been for a while) with limited access to Internet and my private keys, I'll get back to this soon. If we're upgrading error messages, I want to make sure #88 is addressed fully

@naugtur naugtur merged commit ce8d7c5 into naugtur:master Sep 14, 2015
naugtur added a commit that referenced this pull request Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants