Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing body to XHR request #2543

Closed
wants to merge 2 commits into from
Closed

Allow passing body to XHR request #2543

wants to merge 2 commits into from

Conversation

fvieudrin
Copy link

For POST requests for example, it allows to pass a body content to the request as the XHR library can do (option.body) : https://github.com/Raynos/xhr/blob/master/README.md

For POST requests for example, it allows to pass a body content to the request as the XHR library can do (option.body) : https://github.com/Raynos/xhr/blob/master/README.md
@heff
Copy link
Member

heff commented Sep 2, 2015

What would you be posting with the XHR lib built into video.js? Internally we only use it for GETs.

Also in master I believe we're still trying to change to raynos/XHR internally. #2321

@dmlap it'd be great to look back into that before 5.0 goes out.

@fvieudrin
Copy link
Author

I developed a plugin to log video errors, and I have to post many information in json to my web service. I already use this vjs.xhr() for GET calls, so I want to use the same lib for POST.

@heff
Copy link
Member

heff commented Sep 3, 2015

Thanks for the background, that makes sense. I'd like to get the rest of #2318 figured out before we move forward with this one.

It looks like naugtur/xhr#89 will finish it off, if you want to +1 it.

@gkatsev
Copy link
Member

gkatsev commented Sep 25, 2015

We're now using raynos/xhr, so, I think this is covered by that?

@gkatsev
Copy link
Member

gkatsev commented Nov 9, 2015

Closing this as fixed since we're using the XHR module. If it doesn't suffice, please open an issue. Thanks.

@gkatsev gkatsev closed this Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants