Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add getPrevElement in eg.Flicking document #217

Closed
sculove opened this issue May 18, 2016 · 2 comments
Closed

add getPrevElement in eg.Flicking document #217

sculove opened this issue May 18, 2016 · 2 comments
Assignees
@netil
Labels
document flicking
Milestone
1.3.0

Comments

@sculove
Copy link
Contributor

sculove commented May 18, 2016

Description

2016-05-18 3 05 00
@sculove
Copy link
Contributor Author

sculove commented May 19, 2016

the pos.1 property of hold event is omitted
https://github.com/naver/egjs/blob/master/src/flicking.js#L580-L581

@netil
Copy link
Member

netil commented May 31, 2016

  1. getPrevElement method jsdoc tag has been already added.
    https://github.com/naver/egjs/blob/master/src/flicking.js#L1168

  2. pos.1 will be added via new PR.
    https://github.com/naver/egjs/blob/master/src/flicking.js#L659

@netil netil self-assigned this May 31, 2016
@netil netil modified the milestone: 1.3.0 Jun 28, 2016
@netil netil added this to the 1.3.0 milestone Jul 7, 2016
netil added a commit to netil/egjs that referenced this issue Jul 21, 2016
@netil
docs(flicking): Document reinforcement
6f4517e 
Update on description
Grammatical correction

Ref naver#295, naver#217
@netil netil mentioned this issue Jul 21, 2016
Closed
netil added a commit that referenced this issue Jul 25, 2016
@netil
docs(flicking): Document reinforcement
29f05b2 
Update on description
Grammatical correction

Fix #295, #217
Close #311
@netil netil closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
document flicking
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@sculove @netil