docs(flicking): Document reinforcement #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1196,7 +1192,7 @@ eg.module("flicking", ["jQuery", eg, window, document, eg.MovableCoord], functio | |||
|
|
|||
| /** | |||
| * Return either panel is animating or not | |||
| * @ko 현재 애니메이션중인지 여부를 리턴한다. | |||
| * @ko 현재 애니메이션 중인지 여부를 리턴한다. | |||
| * @group egjs | ||
| * @ko 플리킹 UI를 구성한다. | ||
| * @ko 캐로셀 플리킹 UI 구성 컴포넌트 |
There was a problem hiding this comment.
Could you reinforce description? like this.
https://github.com/naver/egjs/blob/master/src/infiniteGrid.js#L210-L212
|
LGTM |
1 similar comment
|
LGTM |
netil
pushed a commit
that referenced
this pull request
Dec 15, 2016
layout is bronken on iOS ref #427, #y-300, #y301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#295, #217
Details
Update on description
Grammatical correction
Preferred reviewers
@naver/egjs-dev