Remove#461 #464
Remove#461 #464
Conversation
| return v; | ||
| })); | ||
| this._waitResource(items, isRefresh); | ||
| layout: function(isRelayout, addItems, isAppend) { |
There was a problem hiding this comment.
The params description should be declared o API doc
http://naver.github.io/egjs/latest/doc/eg.InfiniteGrid.html#layout
There was a problem hiding this comment.
I apply it in #465 pr
also, I will add comment.
| if (isInit) { | ||
| $.each(addItems, function(i, v) { | ||
| v.el.style.position = "absolute"; | ||
| }); |
There was a problem hiding this comment.
addItems seems to be element array. Just wrapping and executing once will be more efficient.
$(addItems).css("position", "absolute");There was a problem hiding this comment.
Ok I will apply in #465 pr
There was a problem hiding this comment.
I restore it.
we should process item.el. so I didn't apply it.
| var max = -Infinity; | ||
| $.each(this._getColItems(false), function(i, v) { | ||
| if (v && v.position.y + v.size.height > max) { | ||
| max = v.position.y + v.size.height; |
There was a problem hiding this comment.
Duplication happens.
Just set local variable to sustain v.position.y + v.size.height and use that for reassignment.
There was a problem hiding this comment.
Ok I will apply in #465 pr
Issue
#461, #454
Details
Preferred reviewers
@netil