Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports remove method #461

Closed
sculove opened this issue Feb 26, 2017 · 2 comments
Closed

supports remove method #461

sculove opened this issue Feb 26, 2017 · 2 comments
Assignees
@sculove
Labels
enhancement infiniteGrid
Milestone
1.5.0

Comments

@sculove
Copy link
Contributor

sculove commented Feb 26, 2017

Description

a remove mothod can remove item by index or element.

remove(index) or remove(element)
@sculove sculove modified the milestone: 1.5.0 Feb 26, 2017
@sculove sculove self-assigned this Feb 26, 2017
@sculove
Copy link
Contributor Author

sculove commented Feb 27, 2017

ref http://masonry.desandro.com/methods.html#remove

sculove added a commit to sculove/egjs that referenced this issue Mar 4, 2017
@sculove
feat(infiniteGrid): skip WIP
a574b36 
ref naver#461
sculove added a commit to sculove/egjs that referenced this issue Mar 4, 2017
@sculove
refactor(infiniteGrid): refactor layout
d66d355 
- support remove method.

ref naver#461
sculove added a commit to sculove/egjs that referenced this issue Mar 4, 2017
@sculove
fix(infiniteGrid): support remove method
7cc5ee7 
- add testcase

ref naver#461
@sculove sculove mentioned this issue Mar 4, 2017
Merged
sculove added a commit that referenced this issue Mar 6, 2017
@sculove
Remove#461 (#464)
7f53f57 
* refactor(infiniteGrid): refactor layout
* feat(infiniteGrid): support remove method.
* docs(infiniteGrid): correct getStatus


ref #454, #461
@sculove sculove closed this as completed Mar 6, 2017
@sculove
Copy link
Contributor Author

sculove commented Mar 6, 2017

we should add jsdoc comment

@sculove sculove reopened this Mar 6, 2017
sculove added a commit to sculove/egjs that referenced this issue Mar 6, 2017
@sculove
docs(infinitGrid): add jsdoc of remove method.
c0105fb 
ref naver#461
@sculove sculove mentioned this issue Mar 6, 2017
Merged
@sculove sculove closed this as completed in 63e19d2 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculove sculove

Labels
enhancement infiniteGrid
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@sculove