Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(infinitGrid): add jsdoc of remove method. #469

Merged
merged 3 commits into from
Mar 7, 2017

Conversation

sculove
Copy link
Contributor

@sculove sculove commented Mar 6, 2017

Issue

#461

Details

  • add jsdoc comment

Preferred reviewers

@netil

@sculove sculove added this to the 1.5.0 milestone Mar 6, 2017
@sculove sculove self-assigned this Mar 6, 2017
@sculove sculove requested a review from netil March 6, 2017 09:51
* @ko 그리드 레이아웃의 카드 엘리먼트를 삭제한다.
* @method eg.InfiniteGrid#remove
* @param {HTMLElement} Card element to be removed <ko>삭제될 카드 엘리먼트</ko>
* @return {Object} Card element removed <ko>삭제된 카드 엘리먼트 정보</ko>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card element removed --> Removed card element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I applied it!

Copy link
Member

@netil netil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sculove sculove merged commit 63e19d2 into naver:master Mar 7, 2017
@sculove sculove deleted the addjsdoc#461 branch March 7, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants